Link mimalloc with --as-needed on Linux#8211
Merged
Conversation
Member
|
I wonder if its worth filing a mimalloc bug to let them know about this issue? |
Member
Author
|
I dunno. I'm still very surprised there are any systems that don't have libatomic.so. libgcc is ubiquitous. |
Member
I guess its always available in the package repo, but not installed on very minimal images? i.e. you can install a base linux setup without needing this particular package (libatomic1) |
The mimalloc CMake code unconditionally adds libatomic to its link dependencies, but it's not actually needed on the modern systems that we're building for. Adding the --as-needed flag causes the linker to only link against the following libraries if they provide symbols that are actually needed. For static linking, we wrap mimalloc's injected dependencies in -Wl,--as-needed since they surface all the way up to the final link line for each tool (I don't think it would hurt to just link all the tools with --as-needed but this seemed cleaner). For dynamic linking, it's sufficient to just make the libmimalloc.so link with --as-needed.
dschuff
force-pushed
the
mimalloc-as-needed
branch
from
00f1de1 to
c71d2df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mimalloc CMake code unconditionally adds libatomic to its link
dependencies, but it's not actually needed on the modern systems
that we're building for. Adding the --as-needed flag causes the
linker to only link against the following libraries if they
provide symbols that are actually needed.
For static linking, we wrap mimalloc's injected dependencies in
-Wl,--as-needed since they surface all the way up to the final
link line for each tool (I don't think it would hurt to just
link all the tools with --as-needed but this seemed cleaner).
For dynamic linking, it's sufficient to just make the libmimalloc.so
link with --as-needed.
As a drive-by cleanup, also make mimalloc a private dependency of
libbinaryen.
Fixes emscripten-core/emsdk#928